Repository navigation
Bump crc32-v2 dependency from 0.0.5 to 0.2.0 - #973
Open
daichifukui wants to merge 1 commit into
Open
daichifukui wants to merge 1 commit into
daichifukui wants to merge 1 commit into
Conversation
Bump to 0.2.0 so downstream distributions can use their packaged version. Adds one new build dependency, crc32-codegen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crc32-v2 = "0.0.5"matches only 0.0.5 under Cargo's 0.0.x version rules.This blocks downstream Linux distributions (e.g. Debian) from building binwalk against their packaged version of crc32-v2, which is going to move on to 0.2.0.
binwalk calls exactly one function from this crate, in two places (src/common.rs, src/structures/jffs2.rs):
crc32_v2::crc32(u32, &[u8]) -> u32.That signature is unchanged from 0.0.4 through 0.2.0.
The implementation was refactored but the underlying table-driven CRC-32 algorithm is the same.
binwalk's Cargo.toml enables no features on this dependency, so only crc32-v2's defaults apply.
The optional
python(pyo3) andnode(napi) bindings added in later releases are not pulled in.crc32-v2 0.2.0 adds one new build dependency,
crc32-codegen0.1.0 (reflected in the Cargo.lock diff).It has no dependencies of its own.