Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to contribute data offset seeking and custom block count values when generating entropy graphs.
I might be hallucinating this, but I think the v2 Python version supported this feature.
I was trying to analyze the entropy of a PE's text section recently when I realized that I had to perform manual preprocessing on the binary to isolate the desired section.
This feature PR adds such functionality in order to make the process a lot less painful.
It also adds the ability to change the block count from the default 2048 to a base2 aligned value of the user's choosing.
This feature essentially is a knob to increase/decrease the granularity of entropy calculation, which can yield much more accurate results for smaller binaries or unreadable data density for really large binaries.
I didn't want to change the contract PostConditions for the blocks() function in entropy.rs so I forced default values instead of throwing errors. It was a minimally invasive approach. Feel free to iterate on this.
And of course, make changes as deemed necessary. I'm not a Rust expert.