add an option for players to enable a moving animation for player models in GUIs - #3
Merged
Merged
Conversation
Owner
|
Thanks @pilloewstin , I'm merging it and will soon release it in a new version. I don't think it will need to be changed too much |
Raconteur32
pushed a commit
that referenced
this pull request
Sep 26, 2026
Domain value type out of gui (atlas open question #3): 9 imports updated, 4 same-package gui usages gained the explicit import. No behavior change; layering allowlist tightened in the follow-up commit of layering-cleanup.
Raconteur32
pushed a commit
that referenced
this pull request
Sep 26, 2026
- changeskin allowlist drops gui.SkinType, gui.library.SkinRecords, gui.library.SkinLifecycle — gui.SkinUtils remains, documented as the one deliberate gui dependency (GPU upload) - the rule now ignores explicit same-package imports (they carry no layering information; surfaced by LibraryFacades after its move) - injection test: a reintroduced gui.SkinType import in changeskin fails the suite, green after revert - atlas refreshed: edges recounted, open questions #3/#4 closed, SkinUtils split recorded as the new candidate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feel free to change if the values or my implementation sucks. This PR is intended to replace #2.
French translations are missing, sorry.