fix(routes): sign the actual message in /signmessage, not an empty slice - #173
Open
orbitalturtle wants to merge 2 commits into
Open
orbitalturtle wants to merge 2 commits into
orbitalturtle wants to merge 2 commits into
Conversation
added 2 commits
September 15, 2026 15:21
message.as_bytes()[message.len()..] is always an empty range, so every signature produced by this endpoint was over an empty string rather than the caller's message.
orbitalturtle
force-pushed
the
fix/sign-message-empty-slice
branch
from
September 15, 2026 20:38
1420f1e to
ddfd096
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #173 +/- ##
=========================================
Coverage ? 87.79%
=========================================
Files ? 16
Lines ? 8478
Branches ? 0
=========================================
Hits ? 7443
Misses ? 1035
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
message.as_bytes()[message.len()..] is always an empty range, so every signature produced by this endpoint was over the empty string rather than the caller's message.