Conversation
… peer msg verified
rmn-boiko
force-pushed
the
test/160-effects-before-verify
branch
from
September 2, 2026 18:59
a7b828e to
0b29e1e
Compare
rmn-boiko
marked this pull request as ready for review
September 2, 2026 18:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tests that reproduce issue #160:
during channel funding, the acceptor applies RGB and wallet side effects before the peer
message that triggered them is verified. A peer can send a well-formed but invalid
funding_created(unrelated consignment, unsupported assignment variant, out-of-range assetpush) and the node has already imported a consignment and mutated its RGB wallet by the time the
check fails — with no rollback. Some late checks are
unreachable!()or an uncheckedsubtraction, so peer input can panic the message handler instead of cleanly closing the channel.