Skip to content

Fix loading configured self-play checkpoints - #673

Open
bagel786 wants to merge 1 commit into
PufferAI:5cfrom
bagel786:fix/load-initial-self-play-checkpoint
Open

Fix loading configured self-play checkpoints#673
bagel786 wants to merge 1 commit into
PufferAI:5cfrom
bagel786:fix/load-initial-self-play-checkpoint

Conversation

@bagel786

Copy link
Copy Markdown

Summary

  • Load base.load_model_path before training starts.
  • Seed the initial self-play pool checkpoint from the loaded policy instead of random initialization.
  • Synchronize the asynchronous rollout actor after loading the primary policy.

Fixes #618.

Related: #632 was an earlier closed attempt from another contributor. This PR independently applies the same narrow load-order fix to the current 5c head.

Validation

  • git diff --check passed.
  • Static inspection verifies that the configured policy load precedes the initial self-play checkpoint save.
  • Static inspection verifies that asynchronous actor parameters are copied from the loaded primary policy.
  • CUDA build/runtime validation was not available on this machine and should run in CI or on a CUDA host before merge.

@bagel786
bagel786 marked this pull request as ready for review August 30, 2026 04:32
Copilot AI lite review requested due to automatic review settings August 30, 2026 04:32

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants