Skip to content

SpiWriteReadTestCase.java was commented out saying manual CS control … - #853

Open
taartspi wants to merge 1 commit into
mainfrom
smokeTest_writeThenRead
Open

taartspi wants to merge 1 commit into
mainfrom
smokeTest_writeThenRead

Conversation

@taartspi

Copy link
Copy Markdown
Contributor

…required. Access to the spi BMx chips should use writeThenRead and not use an additional GPIO. Deleted the testcase

…required. Access to the spi BMx chips should use writeThenRead and not use an additional GPIO. Deleted the testcase
@github-actions

Copy link
Copy Markdown

Groma architecture comparison

Changes Added Modified Removed
Components 0 2 0
Relationships 0 0 0
flowchart TB
  subgraph n0_group_pi4j_test["Test"]
    n1_main["Main"]:::modified
    subgraph n2_group_group_pi4j_test_Smoke_Tests["Smoke Tests"]
      n3_spiwritereadtestcase["SpiWriteReadTestCase"]:::modified
    end
  end
  classDef added fill:#dafbe1,stroke:#1a7f37,color:#1f2328
  classDef modified fill:#fff8c5,stroke:#9a6700,color:#1f2328
  classDef removed fill:#ffebe9,stroke:#cf222e,color:#1f2328,stroke-dasharray:4 3
  classDef context fill:#f6f8fa,stroke:#8c959f,color:#57606a
Loading

🟢 added · 🟡 modified · 🔴 removed · grey: unchanged component with a changed relationship

Changed components
Component Location Change Files Lines
Main Test 🟡 modified Main.java +0 −1
SpiWriteReadTestCase Test › Smoke Tests 🟡 modified SpiWriteReadTestCase.java +0 −79

Download the full before/after architecture map from this run's artifacts (kept 14 days). The current map is also published at https://www.pi4j.com/groma/.

@sonarqubecloud

Copy link
Copy Markdown

@taartspi
taartspi requested a review from eitch November 21, 2026 19:50

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant