Skip to content

Remove the confusing and error-prone close/shutdownInternal dance - #768

Merged
eitch merged 7 commits into
Pi4J:mainfrom
stefanhaustein:remove-shutdownInternal
Sep 30, 2026
Merged

eitch merged 7 commits into
Pi4J:mainfrom
stefanhaustein:remove-shutdownInternal

Conversation

@stefanhaustein

@stefanhaustein stefanhaustein commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Make close() the only close method and get rid of shutdownInternal altogether.

As suggested in #767

@stefanhaustein
stefanhaustein requested review from eitch and removed request for eitch September 28, 2026 18:51
@stefanhaustein
stefanhaustein marked this pull request as draft September 28, 2026 19:04
@stefanhaustein
stefanhaustein marked this pull request as ready for review September 28, 2026 19:14
eitch
eitch previously approved these changes Sep 29, 2026

@eitch eitch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few points, nothing major.

@sonarqubecloud

Copy link
Copy Markdown

@eitch eitch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eitch
eitch merged commit f56ffd8 into Pi4J:main Sep 30, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants