Skip to content

Fs90r new cmd - #172

Merged
stefanhaustein merged 9 commits into
mainfrom
fs90r_new_cmd
Nov 6, 2026
Merged

stefanhaustein merged 9 commits into
mainfrom
fs90r_new_cmd

Conversation

@taartspi

Copy link
Copy Markdown
Collaborator

No description provided.

@taartspi

Copy link
Copy Markdown
Collaborator Author

Requires merge of driver changes. Created a PR now to facilitate conversations

TODO marks the topic of conversation

@taartspi
taartspi marked this pull request as draft October 26, 2026 18:21
updates to Fs90r to  use new command structure.  At present there are 3 places marked by TODO.  They are questions

# Conflicts:
#	src/main/java/com/pi4j/devices/fs90r/Fs90rApp.java
Updates trying parameterizedAction
updates to Fs90r to  use new command structure.  At present there are 3 places marked by TODO.  They are questions
unit test updates
capture working code before next changes
update for provider change in core.
Updates trying parameterizedAction
updates to Fs90r to  use new command structure.  At present there are 3 places marked by TODO.  They are questions
unit test updates
capture working code before next changes
update for provider change in core.
Updates trying parameterizedAction
updates to Fs90r to  use new command structure.  At present there are 3 places marked by TODO.  They are questions
@taartspi

taartspi commented Nov 2, 2026

Copy link
Copy Markdown
Collaborator Author

requires the drivers changes be merged #194

@taartspi
taartspi marked this pull request as ready for review November 2, 2026 00:52
readme examples
unit test updates
capture working code before next changes
update for provider change in core.
Updates trying parameterizedAction
updates to Fs90r to  use new command structure.  At present there are 3 places marked by TODO.  They are questions
@taartspi

taartspi commented Nov 3, 2026

Copy link
Copy Markdown
Collaborator Author

@stefanhaustein ready for review.

There is a method that uses percent, validate direction is set.

There still is a method taking degrees. Readme explains this is for users who understand the servo. The method doesn't care about direction that was set, it does however set the direction based on the degree supplied. This way if the user passes degrees, but later changes to the percent method that percent method will validate against the direction previously set by degree.

readme examples
unit test updates
capture working code before next changes
update for provider change in core.
Updates trying parameterizedAction
updates to Fs90r to  use new command structure.  At present there are 3 places marked by TODO.  They are questions

# Conflicts:
#	src/main/java/com/pi4j/devices/fs90r/Fs90rApp.java
#	src/main/java/com/pi4j/devices/fs90r/README.md
@taartspi

taartspi commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator Author

as I did the many other devices I found the code to manipulate the actual device was usually small and simple, few devices had complicated register sets. The example to use the device was always the work. Not rocket science but what should be demonstrated at the register level and when a convenience method was appropriate.

I believe I incorporated the comments/discussions as we moved to using paramterizedAction to process the users input param. Ready for review @stefanhaustein

@stefanhaustein
stefanhaustein merged commit a0d2363 into main Nov 6, 2026
5 of 6 checks passed
@taartspi
taartspi deleted the fs90r_new_cmd branch November 6, 2026 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants