Repository navigation
Fs90r new cmd - #172
Fs90r new cmd#172
Conversation
… places marked by TODO. They are questions
|
Requires merge of driver changes. Created a PR now to facilitate conversations TODO marks the topic of conversation |
updates to Fs90r to use new command structure. At present there are 3 places marked by TODO. They are questions # Conflicts: # src/main/java/com/pi4j/devices/fs90r/Fs90rApp.java
Updates trying parameterizedAction updates to Fs90r to use new command structure. At present there are 3 places marked by TODO. They are questions
unit test updates capture working code before next changes update for provider change in core. Updates trying parameterizedAction updates to Fs90r to use new command structure. At present there are 3 places marked by TODO. They are questions
unit test updates capture working code before next changes update for provider change in core. Updates trying parameterizedAction updates to Fs90r to use new command structure. At present there are 3 places marked by TODO. They are questions
|
requires the drivers changes be merged #194 |
readme examples unit test updates capture working code before next changes update for provider change in core. Updates trying parameterizedAction updates to Fs90r to use new command structure. At present there are 3 places marked by TODO. They are questions
|
@stefanhaustein ready for review. There is a method that uses percent, validate direction is set. There still is a method taking degrees. Readme explains this is for users who understand the servo. The method doesn't care about direction that was set, it does however set the direction based on the degree supplied. This way if the user passes degrees, but later changes to the percent method that percent method will validate against the direction previously set by degree. |
readme examples unit test updates capture working code before next changes update for provider change in core. Updates trying parameterizedAction updates to Fs90r to use new command structure. At present there are 3 places marked by TODO. They are questions # Conflicts: # src/main/java/com/pi4j/devices/fs90r/Fs90rApp.java # src/main/java/com/pi4j/devices/fs90r/README.md
|
as I did the many other devices I found the code to manipulate the actual device was usually small and simple, few devices had complicated register sets. The example to use the device was always the work. Not rocket science but what should be demonstrated at the register level and when a convenience method was appropriate. I believe I incorporated the comments/discussions as we moved to using paramterizedAction to process the users input param. Ready for review @stefanhaustein |
No description provided.