Add new transition matrix and optimization workflow - #4101
Conversation
mdietze
left a comment
mdietze
left a comment
There was a problem hiding this comment.
Need to run make document and commit the updated /man and NAMESPACE files
|
|
||
| The crop-transition state space is: | ||
|
|
||
| ```text |
|
|
||
| Each row of the matrix therefore sums to 1. | ||
|
|
||
| ## 3. Cleaning unknown crop states |
There was a problem hiding this comment.
For the future: this should be done on the LandIQ in general, not just for calculating transitions. In that context, the observed CDL data also plays a role. Indeed, is Sarah's code not already gapfilling these values?
| A parcel can contain multiple LandIQ observations within the same year because | ||
| multiple growing seasons may be recorded. | ||
|
|
||
| These observations are reduced to one annual crop state. |
There was a problem hiding this comment.
| These observations are reduced to one annual crop state. | |
| To simplify the transition modeling, these observations are reduced to predicting changes in the dominant crop. |
| ``` | ||
|
|
||
| Crop optimization is performed once because the current BAU and NBS scenarios | ||
| use the same crop acreage targets. |
There was a problem hiding this comment.
Would be helpful to provide a bit of info about what to do if you have different scenarios or new/additional scenarios. For example, do you run the code more than once, and if so how does that change how you specify inputs and outputs so that you can ensure downstream code uses the correct scenario-specific inputs.
| For each county, the starting crop distribution is constructed from each | ||
| parcel's latest observed crop state at or before: | ||
|
|
||
| ```text |
There was a problem hiding this comment.
Similar to comments on the phenology workflow, in general you use text blobs too much and there are a lot of places you can simplify to just writing sentences. Also, in cases like this one, you should be clarifying how to set these sort of variables in the config rather than just telling us what the current default value is.
| 2023 | ||
| ``` | ||
|
|
||
| Parcel acreage is summed by crop state to create: |
There was a problem hiding this comment.
| Parcel acreage is summed by crop state to create: | |
| Parcel acreage is summed by crop state to create `X0`, the county crop acreage vector used by the optimizer. |
| @@ -0,0 +1,447 @@ | |||
| # Crop Transition Matrices and Scenario Optimization | |||
There was a problem hiding this comment.
If both this file and the previous are numbered 01, how does the user know which to read/run first?
…ansition-matrix-optimization.md This is an old documentation version, removing for cleaning. 01-matrix_development.md is the correct tutorial in this file
Co-authored-by: Michael Dietze <dietze@bu.edu>
Co-authored-by: Michael Dietze <dietze@bu.edu>
Co-authored-by: Michael Dietze <dietze@bu.edu>
Co-authored-by: Michael Dietze <dietze@bu.edu>
| irrigation_max: 150 | ||
|
|
||
|
|
||
| scc: |
There was a problem hiding this comment.
Make sure scripts are not hard coded to run with this as the default
e56c265
2 participants
Submitting a new PR for this new/cleaned branch on transition matrix and matrix optimization development due to multiple changes overtime
PR includes:
modules/data.remote/R/transition_functions.RMain outputs
The workflow produces:
crops_full_counties.csvcrop_year_states_cleaned.csvThe optimized matrices are used by the downstream parcel crop-prediction workflow.