Conversation
Signed-off-by: Gaurav Chaudhary <chaudharygaurav2004@gmail.com>
infotroph
reviewed
Sep 19, 2026
infotroph
approved these changes
Sep 19, 2026
Merged
via the queue into
PecanProject:develop
with commit Sep 19, 2026
2caee58
31 of 32 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
segment_dataframe()usingevent_jsonwhencrop_changesis absent. Verify site filtering, segment dates and IDs, crop codes, and the initial PFT.sipnet.infiles: the first segment has noRESTART_IN, each segment writes its ownRESTART_OUT, and subsequent segments read the previous segment’s output.No production code or dependencies are changed.
Motivation and Context
Closes #4021.
Adds the two coverage improvements suggested during review of #4008, protecting JSON-based segmentation and the restart chain without requiring a SIPNET executable.
Validation
RUN_TESTS=TRUE: failed because existing tests usePEcAn.settingswithout declaring it as a test dependency. The same failure was reproduced on an unchanged baseline copy.The package-check failure remains unresolved, so the overall test checklist below is left unchecked.
Review Time Estimate
Types of changes
Test coverage only; no runtime behavior changes.
Checklist:
Check the license agreement yourself before submitting, and the citation checkbox only if your name is already listed.