Skip to content

EVI download and processing code for PEPRMT model - #4093

Open
abbylewis wants to merge 6 commits into
PecanProject:developfrom
abbylewis:evi_helpers
Open

abbylewis wants to merge 6 commits into
PecanProject:developfrom
abbylewis:evi_helpers

Conversation

@abbylewis

Copy link
Copy Markdown
Collaborator

@infotroph
Added EVI functions to PEcAn.remote, and added code to integrate these functions into the PEPRMT workflow. The EVI code takes a long time to run, so I still use the pre-calculated values by default, but everything should be set up to get new EVI values on demand if desired

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • [ x] I agree that PEcAn Project may distribute my contribution under any or all of
    • the same license as the existing code,
    • and/or the BSD 3-clause license.
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mdietze

mdietze commented Sep 3, 2026

Copy link
Copy Markdown
Member

@abbylewis to file under "wish we'd chatted earlier" -- There's already a LOT of code in PEcAn dedicated to downloading, processing, and analyzing HLS data (primarily lead by @sarahkanee), as well as a general NASA Earth Data download function developed by @DongchenZ that I've been strongly pushing people to use rather than generating product-specific functions (as one function is ultimately easier to maintain and use). I don't want to create a ton of extra work for you, but I'd definitely encourage you to touch base with Sarah and Dongchen to think about how your workflow could take advantage of existing modules, as that's kinda key to the PEcAn philosophy (solve a problem once across models and across data products rather than having a plethora of one-off solutions). As a specific example, it looks like you're fitting a phenological double-logistic using methods developed in 2006, while Sarah's running the current operational Multi-Source Land Surface Phenology (MSLSP) algorithm (i.e., the "official" HLS phenology algorithm)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants