Repository navigation
Stop search engine query params lookup from warning on tldextract 5.3 - #37
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
xyu
marked this pull request as ready for review
November 4, 2026 23:48
Member
Author
|
Closes #33 by making the same change but compatible across new and old versions |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Listing query params by search engine domain no longer reads tldextract's deprecated
registered_domain. It returns the same domains as before on every tldextract version.Also releases this as 0.8.1. The search engine list is unchanged, so referrer classification is the same as 0.8.0.
Why are these changes being made?
tldextract 5.3 warns on each read of
registered_domain, and 6.0 removes it. This is the last read left in Parse.ly's referrer path after parselyutils#843.Testing
pip install -r requirements.txt && pip install . <tldextract> && pytest -q:python:3.9-bullseyesetup.pyminimum)python:3.9-bullseyepython:3.9-bullseyepython:3.13-bookwormThe 0.8.1 build (
python -m build && twine check dist/*inpython:3.9-bullseye) passes, and its wheel installed with tldextract 5.3.0 passes the same 16 tests. Its metadata reads:With master's
serpextract.pyand tldextract 5.3.0, the new test fails on the warning:1 failed, 15 passed, 20943 warnings.Testing instructions
Confirm no read of the deprecated property is left:
After merging, a PyPI maintainer tags the merge commit and uploads the same files to PyPI, devpi and the GitHub release:
🤖 Generated with Claude Code