Skip to content

Stop search engine query params lookup from warning on tldextract 5.3 - #37

Merged
xyu merged 3 commits into
masterfrom
xyu/no-registered-domain-deprecation
Nov 5, 2026
Merged

xyu merged 3 commits into
masterfrom
xyu/no-registered-domain-deprecation

Conversation

@xyu

@xyu xyu commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

Proposed changes

Listing query params by search engine domain no longer reads tldextract's deprecated registered_domain. It returns the same domains as before on every tldextract version.

Also releases this as 0.8.1. The search engine list is unchanged, so referrer classification is the same as 0.8.0.

Why are these changes being made?

tldextract 5.3 warns on each read of registered_domain, and 6.0 removes it. This is the last read left in Parse.ly's referrer path after parselyutils#843.

Testing

pip install -r requirements.txt && pip install . <tldextract> && pytest -q:

Image tldextract Result
python:3.9-bullseye 1.2 (the setup.py minimum) 16 passed
python:3.9-bullseye 3.4.0 16 passed
python:3.9-bullseye 5.3.0 16 passed
python:3.13-bookworm 5.4.0 (latest) 16 passed

The 0.8.1 build (python -m build && twine check dist/* in python:3.9-bullseye) passes, and its wheel installed with tldextract 5.3.0 passes the same 16 tests. Its metadata reads:

Version: 0.8.1
Requires-Python: >=3.9
Requires-Dist: iso3166>=0.4
Requires-Dist: tldextract>=1.2
Requires-Dist: ruamel.yaml

With master's serpextract.py and tldextract 5.3.0, the new test fails on the warning: 1 failed, 15 passed, 20943 warnings.

Testing instructions

  • Confirm no read of the deprecated property is left:

    git grep -n registered_domain -- serpextract
    
    serpextract/serpextract.py:498:        # Same value as registered_domain, which warns on tldextract 5.3 and is gone in 6.
    
  • After merging, a PyPI maintainer tags the merge commit and uploads the same files to PyPI, devpi and the GitHub release:

    git tag v0.8.1 && git push origin v0.8.1
    python -m build && twine upload dist/serpextract-0.8.1*
    devpi use https://pypi.cogtree.com/cogtree/main && devpi login cogtree && devpi upload dist/serpextract-0.8.1*
    gh release create v0.8.1 dist/serpextract-0.8.1* --repo Parsely/serpextract
    
    View at:
    https://pypi.org/project/serpextract/0.8.1/
    

🤖 Generated with Claude Code

xyu and others added 2 commits November 4, 2026 23:44
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@xyu
xyu marked this pull request as ready for review November 4, 2026 23:48
@xyu
xyu requested a review from a team November 4, 2026 23:48
@xyu

xyu commented Nov 5, 2026

Copy link
Copy Markdown
Member Author

Closes #33 by making the same change but compatible across new and old versions

@xyu
xyu requested a review from jblz November 5, 2026 00:06
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@xyu
xyu merged commit 28e30ca into master Nov 5, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant