Skip to content

Drop unused pylru dependency - #34

Merged
xyu merged 1 commit into
masterfrom
remove-pylru
Oct 28, 2026
Merged

xyu merged 1 commit into
masterfrom
remove-pylru

Conversation

@xyu

@xyu xyu commented Oct 28, 2026

Copy link
Copy Markdown
Member

Proposed changes

serpextract no longer depends on pylru.

Why are these changes being made?

serpextract created a pylru cache at import time but never read or wrote it. That one line made pylru a dependency of every Parse.ly project that installs serpextract. Parse.ly's own code no longer uses pylru, so this is what still keeps it installed in dash, ML and the engineering monorepo.

Testing

pip install -r requirements.txt && pip install . && pytest -q in python:3.9-bullseye, with pylru confirmed absent from the environment:

pylru installed: False
Requires: iso3166, ruamel.yaml, tldextract
15 passed

Testing instructions

  • Confirm nothing else references the removed cache:

    git grep -n -i lru -- '*.py' setup.py requirements.txt
    
    (no output)
    

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@xyu xyu mentioned this pull request Oct 28, 2026
1 task
@xyu
xyu requested a review from a team October 28, 2026 17:16
@xyu
xyu merged commit 763e460 into master Oct 28, 2026
6 checks passed
@xyu
xyu deleted the remove-pylru branch October 28, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant