Repository navigation
Drop unused pylru dependency - #34
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
serpextract no longer depends on pylru.
Why are these changes being made?
serpextract created a pylru cache at import time but never read or wrote it. That one line made pylru a dependency of every Parse.ly project that installs serpextract. Parse.ly's own code no longer uses pylru, so this is what still keeps it installed in dash, ML and the engineering monorepo.
Testing
pip install -r requirements.txt && pip install . && pytest -qinpython:3.9-bullseye, with pylru confirmed absent from the environment:Testing instructions
Confirm nothing else references the removed cache:
🤖 Generated with Claude Code