Skip to content

Removing v4 warnings in init and docs banner - #2835

Draft
erikvansebille wants to merge 2 commits into
Parcels-code:mainfrom
erikvansebille:v4-release
Draft

Removing v4 warnings in init and docs banner#2835
erikvansebille wants to merge 2 commits into
Parcels-code:mainfrom
erikvansebille:v4-release

Conversation

@erikvansebille

Copy link
Copy Markdown
Member

Description

This PR removes the v4 warnings in the parcels.__init__ and the banner on the documentation page; in preparation for the v4 release

Checklist

AI Disclosure

None

Comment thread docs/conf.py
"type": "fontawesome",
}
],
"announcement": "WARNING: This documentation is built for v4 of Parcels, which is unreleased and in active development. Use the version switcher in the bottom right to select your version of Parcels, or see <a href='https://docs.parcels-code.org/'>stable docs</a>.",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about

"announcement": "Parcels v4 has been released! 🎉 See <a href='https://parcels-code.org/...'>our release blog post</a> for more info",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it makes more sense to put the new banner in a future PR

  1. Remove warning and banner
  2. Do release
  3. Post blog post
  4. Add new banner in, which links to now posted blog post

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I was also thinking about putting a new banner up post-release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

2 participants