Repository navigation
Move MenuType API to utilize "real" boolean switch for BlockEntity's - #13439
Open
Y2Kwastaken wants to merge 7 commits into
Open
Y2Kwastaken wants to merge 7 commits into
Y2Kwastaken wants to merge 7 commits into
Conversation
Y2Kwastaken
force-pushed
the
lectern-behavior
branch
2 times, most recently
from
December 31, 2025 17:45
a1eec90 to
febd434
Compare
Y2Kwastaken
changed the title
Y2Kwastaken
force-pushed
the
lectern-behavior
branch
3 times, most recently
from
February 4, 2026 18:10
bb7bfb3 to
c65f85e
Compare
Y2Kwastaken
force-pushed
the
lectern-behavior
branch
from
April 15, 2026 21:09
c65f85e to
199f9d1
Compare
Strokkur424
approved these changes
Apr 15, 2026
Y2Kwastaken
force-pushed
the
lectern-behavior
branch
from
July 30, 2026 22:13
199f9d1 to
f41f85a
Compare
Y2Kwastaken
commented
Aug 6, 2026
Y2Kwastaken
changed the title
Member
|
Looking at setChanged calls, this causes chunk updates that should be behind the real flag as well |
Y2Kwastaken
force-pushed
the
lectern-behavior
branch
from
August 26, 2026 14:07
c667bf8 to
8c9043b
Compare
Y2Kwastaken
force-pushed
the
lectern-behavior
branch
from
October 13, 2026 14:51
1220aed to
9e29da3
Compare
Member
|
I make a few tests, currently with PlayerTakeLecternBookEvent/PlayerLecternPageChangeEvent if try to get the Lectern i get a NPE, not sure what can be a good solution for this.. |
…/lectern-behavior # Conflicts: # paper-server/patches/features/0017-Delay-close-callbacks-for-chests.patch
Doc94
approved these changes
Oct 26, 2026
Doc94
left a comment
Doc94
left a comment
Member
There was a problem hiding this comment.
Tested with lectern a few blocks (ref: https://pastes.dev/gpMp1Tck3d) this include a "breaking change" for the Lectern events but its what can happen and feel its better rather than try to make a fake block what can cause other issues...
papermc-projects
Bot
moved this from Awaiting review
to Delayed approval
in Paper PR Queue
papermc-projects
Bot
moved this from Delayed approval
to Full approval
in Paper PR Queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes how we handle fake BlockEntity instances. There is a change in logic by adding a "real" field to BlockEntity we can deterministically tell if the BlockEntities are "real." By this real means that it is in world currently and should have somewhat limited capabilities compared to its in world counterparts.
Previously, fake BlockEntity instances were given the player's world without limitations to get around internal assumptions. While somewhat functional, this caused some nasty unintended side effects around placement state, event broadcasting, and redstone/game events. The goal here is to keep fake block entities truly unplaced, while still allowing safe interaction paths where needed.
The goal here is also not to necessarily sacrifice event functionality as much as possible when it comes to Menus as part of their power is being able to utilize normal Bukkit events where otherwise you would have to delegate to NMS or other hacks.
This is good for review its a bug fix, even on latest it fixes the bug still.
Fixes #13438