Skip to content

fix: 일괄 변경 결과의 미리보기 이후 변경 라벨 #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yessjun merged 1 commit into from
Sep 28, 2026
Merged

fix: 일괄 변경 결과의 미리보기 이후 변경 라벨 #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/bulk-change.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ describe('bulk change offers and labels', () => {
test('unknown codes and values render as themselves', () => {
expect(labelForBulkReason('NOT_MEMBER')).toBe('워크스페이스 구성원 아님')
expect(labelForBulkReason('SOMETHING_NEW')).toBe('SOMETHING_NEW')
expect(labelForBulkResult('STALE')).toBe('그사이 바뀜')
expect(labelForBulkResult('STALE')).toBe('미리보기 이후 변경됨')
expect(labelForBulkResult('LATER')).toBe('LATER')
expect(formatDiffValue('rpm', null)).toBe('서비스 기본값')
expect(formatDiffValue('passthroughEndpoints', [])).toBe('부여 안 됨')
Expand Down
2 changes: 1 addition & 1 deletion src/lib/labels.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ export const BULK_CHANGE_RESULT_LABELS: Record<AdminBulkChangeResult, string> =
APPLIED: '적용됨',
UNCHANGED: '변경 없음',
SKIPPED: '건너뜀',
STALE: '그사이 바뀜',
STALE: '미리보기 이후 변경됨',
}

/** A code this build has no label for renders as itself, as the kind labels do. */
Expand Down
4 changes: 2 additions & 2 deletions src/pages/AdminBulkChangePage.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ describe('AdminBulkChangePage', () => {
await user.click(screen.getByRole('button', { name: '2개에 적용' }))
const result = await screen.findByRole('table', { name: '일괄 변경 결과' })
expect(within(result).getByRole('row', { name: /initial-binding-key/ })).toHaveTextContent(
'그사이 바뀜',
'미리보기 이후 변경됨',
)
expect(within(result).getByRole('row', { name: /pending-admin-key/ })).toHaveTextContent(
'적용됨',
Expand Down Expand Up @@ -346,7 +346,7 @@ describe('AdminBulkChangePage', () => {
setBulkGrant(uuid(171), uuid(42), 'VIEWER')
await user.click(screen.getByRole('button', { name: '1개에 적용' }))
expect(await screen.findByRole('table', { name: '일괄 변경 결과' })).toHaveTextContent(
'그사이 바뀜',
'미리보기 이후 변경됨',
)
})

Expand Down
Loading