Skip to content

feat(security): let a consumer supply the access token via setAccessTokenResolver - #324

Draft
gcutrini wants to merge 2 commits into
v4.xfrom
feat/access-token-resolver
Draft

feat(security): let a consumer supply the access token via setAccessTokenResolver#324
gcutrini wants to merge 2 commits into
v4.xfrom
feat/access-token-resolver

Conversation

@gcutrini

Copy link
Copy Markdown
Contributor

uicore fetches the access token internally, and a consumer has no way to supply one. Several uicore modules call getAccessToken, so the source must be injectable inside uicore rather than overridden by the consumer.

Add setAccessTokenResolver to security/methods: when a resolver is registered, getAccessToken delegates to it; otherwise the built-in flow is unchanged. Passing a non-function resets to the built-in.

The resolver is module-level state, so also externalize security/methods in the webpack build. That way every uicore lib entry shares one methods instance and sees the registered resolver; otherwise an entry that inlines its own copy keeps its own null resolver and ignores it.

@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…okenResolver

Add setAccessTokenResolver: when a resolver is registered, getAccessToken delegates to it; otherwise the built-in flow is unchanged. Passing a non-function resets to the built-in.

The resolver is module-level state, so externalize security/methods in the webpack build so every uicore lib entry shares one instance and sees the registered resolver.
Delegates to a registered resolver, a later resolver replaces the previous one, and a non-function argument clears it.
@gcutrini
gcutrini force-pushed the feat/access-token-resolver branch from 670afb2 to 63e4c51 Compare August 24, 2026 17:42
@gcutrini
gcutrini changed the base branch from main to v4.x August 24, 2026 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant