Import MUI and lodash by subpath, not their barrels - #323
Merged
Conversation
Two consumer-bundle-size fixes, same pattern — import a subpath instead of a library's root barrel, so anything that bundles uicore pulls only what's used: - company-input-v2: TextField/Autocomplete/Typography from their @mui/material/* subpaths instead of the @mui/material barrel (which pulls the whole component library). - query-actions: debounce from lodash/debounce instead of whole lodash (it uses only debounce). Behaviour is identical — the barrels re-export these exact modules; only the import paths change.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: https://app.clickup.com/t/86bbk4x0m
Two consumer-bundle-size fixes, same pattern — import a subpath instead of a library's root barrel, so anything that bundles uicore pulls only what's used:
TextField/Autocomplete/Typographyfrom their@mui/material/*subpaths instead of the@mui/materialbarrel (which pulls the whole component library).debouncefromlodash/debounceinstead of wholelodash(it uses onlydebounce).Behaviour is identical — the barrels re-export these exact modules; only the import paths change.