Display IPP-over-USB printers with locally connected devices - #460
Draft
SinghCod3r wants to merge 4 commits into
Draft
Display IPP-over-USB printers with locally connected devices#460SinghCod3r wants to merge 4 commits into
SinghCod3r wants to merge 4 commits into
Conversation
Collaborator
Author
|
@alexpevzner , also added the Search Printer in ui too. |
This replaces the transient 'Searching for printers...' tree view row with a centered Gtk.Spinner inside a Gtk.Overlay. It also preserves the minimum 0.5s visibility time. Additionally, this stops the global bottom-left spinner from spinning concurrently during the discovery phase.
SinghCod3r
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
IPP-over-USB printers discovered through DNS-SD can currently be classified as
network printers in the New Printer dialog.
This change identifies IPP-over-USB devices using their DNS-SD IPP URI together
with their loopback address, while keeping normal LAN IPP printers classified
as network printers.
The New Printer dialog now presents IPP-over-USB devices as local printers.
Changes
Testing
pytest -q test_dnssdresolve.py— 14 passedpytest -q test_PhysicalDevice.py— 2 passedgit diff --check— passedThe full test suite currently reports 16 passed and 1 unrelated failure in
test_ppds.py::test_ppdsinvolving existing PPD ID matching tests.I do not currently have a Xerox B235 available for physical hardware
validation.