Repository navigation
test(shadow): make the shadow-mode tests pass on Windows - #213
Merged
Merged
Conversation
The tests set HOME, but Path.home() on Windows reads USERPROFILE, and they asserted POSIX permission bits that NTFS doesn't have (it uses ACLs, and %LOCALAPPDATA% is private to the user by default). Five tests failed on windows-latest since the shadow-mode commit, which blocked the release train. Point the home directory at the temp dir on every platform and check mode bits only on POSIX. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five shadow-mode tests have failed on windows-latest since the shadow-mode commit (10-18 00:16), which makes the release train refuse to publish. That is why #212 (the phone redesign) hasn't shipped.
HOME, butPath.home()on Windows readsUSERPROFILE. They now point the home directory at the temp dir on every platform.%LOCALAPPDATA%is private to the user by default). Mode checks now run only on POSIX.Test-only.
tests/test_engine/test_shadow_mode.pypasses on macOS (25).🤖 Generated with Claude Code