Park the StateMachines cause-offering expectation to unblock master's CI - #858
Closed
romanett wants to merge 1 commit into
Closed
Park the StateMachines cause-offering expectation to unblock master's CI#858romanett wants to merge 1 commit into
romanett wants to merge 1 commit into
Conversation
The StateMachines client never sees its Start cause become executable once the machine is Idle, which fails ClientReceivesItsNotifications on every current package set - the 2.0.0-preview.4 packages of CI just as the current GitHub Packages builds - and keeps the Test Samples job red on every master build. This is a defect in how the sample and the stack report Executable for causes, not package lag, so the expectation goes into the known-issue machinery the suite has for exactly this: reported as ignored with the reason, and failing the moment it starts passing so the entry cannot rot. The subscription fixture gets the same known-issue list SampleClientTests already has. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The
Test Samplesjob is red on every master build:ClientReceivesItsNotifications(StateMachines)fails because the StateMachines client never sees itsStartcause become executable once the machine is Idle. It fails identically on the2.0.0-preview.4packages CI uses and on the current GitHub Packages master builds (verified on2.0.280.50326-preview), so it is not package lag but a defect in how the sample and the stack reportExecutablefor causes - one that deserves its own fix.Until that fix exists, this PR moves the expectation into the known-issue machinery the suite has for exactly this situation:
WorkshopClientSubscriptionTestsgets the sames_knownIssueslistSampleClientTestsalready has, the StateMachines entry carries the reason, the test reports as ignored instead of failed, and it fails the moment the defect is fixed so the entry cannot rot.docs/TESTING.mdrecords it.Extracted from #808 (which needs it for the same reason on the GitHub Packages builds) so master's CI goes green without waiting for the feed switch. The other sample fix riding on #808 - qualifying the hand-built GDS registrar's method BrowseNames with the Part 21 Onboarding namespace for the newer
OnboardingClientresolution - cannot come along: the generatedOpc.Ua.Onboardingconstants it needs do not exist in2.0.0-preview.4, and at preview.4 the ns=0 contract still holds.Verified locally at
2.0.0-preview.4: the client project builds clean and the subscription fixture reports 6 passed, 1 ignored (StateMachines, with the recorded reason).Related Issues
Test Samplesjob on master; extracted from Switch the preview feed to GitHub Packages and adopt the DI config-XML loading #808Types of changes
Checklist
Further comments
The underlying defect -
Executablenot following the declared causes for the current state on the fluent state-machine surface - still needs a root-cause fix, either in the sample's client-side attribute reading or in the stack's cause reporting. The known-issue entry names it and will demand its own removal when that lands.🤖 Generated with Claude Code