[18][UPD] add empty batch remove when job vaccum - #916
Open
julienCozo wants to merge 1 commit into
Open
Conversation
julienCozo
force-pushed
the
18.0-add-queue-job-batch-vaccum
branch
from
March 24, 2026 15:40
3391f84 to
204eb72
Compare
julienCozo
force-pushed
the
18.0-add-queue-job-batch-vaccum
branch
from
March 24, 2026 15:44
204eb72 to
84085d3
Compare
|
@julienCozo can you rename the PR "[18.0][IMP] queue_job_batch: vacuum empty batches" |
amh-mw
suggested changes
Apr 14, 2026
Comment on lines
+42
to
+44
| for batch in batches: | ||
| if not batch.job_ids: | ||
| batch.unlink() |
Member
There was a problem hiding this comment.
Redundant with ("job_ids", "=", False) above, therefore?
Suggested change
| for batch in batches: | |
| if not batch.job_ids: | |
| batch.unlink() | |
| batches.unlink() |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
Bot
added
the
stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When queue jobs performing its vaccuum, delete also queue batch where job_ids is 0.