Conversation
Contributor
|
Hi @Fkawala, @legalsylvain, |
Currenlty when scanning a packaging, the packaging quantity is not correctly handled and defaults to 1. This commit adds a condition that if the product scanned is a packaging, it should not be handled as a weighted product
mihien
force-pushed
the
16.0-fix-pos_tare-product-packaging
branch
from
September 14, 2026 14:30
ecee1ca to
9cb37d7
Compare
huguesdk
approved these changes
Oct 5, 2026
huguesdk
left a comment
huguesdk
left a comment
Member
There was a problem hiding this comment.
good catch, thanks for the fix! lgtm, but please add a comment above the added code explaining why it is there.
note: there is a typo in the commit message: Currenlty → Currently. but i think the commit message shouldn’t be that verbose with a “Currently… (…) This commit…”. something like this would be clear enough:
[FIX] pos_tare: fix conflict with product packaging
ensure that barcode scans of products packages work correctly instead of
having the quantity set to 1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when scanning a packaging, the packaging quantity is not correctly handled and defaults to 1.
This PR add a condition that if the product scanned is a packaging, it should not be handled as a weighted product.