Skip to content

[18.0][ADD] pos_show_variant_image: show product variant image in attribute popup - #1595

Open
cvinh wants to merge 1 commit into
OCA:18.0from
invitu:18.0-add_pos_show_product_image
Open

cvinh wants to merge 1 commit into
OCA:18.0from
invitu:18.0-add_pos_show_product_image

Conversation

@cvinh

@cvinh cvinh commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

The POS attribute selection popup (opened when a product has attributes) never showed a product image, even though it already resolves and displays the matching product.product variant.

This adds the image of the currently selected variant, updating live as the cashier changes attribute values, reusing the existing native product.product.getImageUrl() method.

Assisted-by: Claude (Anthropic)

@OCA-git-bot OCA-git-bot added series:18.0 mod:pos_show_product_image Module pos_show_product_image labels Aug 11, 2026
@cvinh
cvinh force-pushed the 18.0-add_pos_show_product_image branch 2 times, most recently from 466a84a to c667575 Compare August 17, 2026 21:34
@cvinh

cvinh commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

resolves #1251 (comment)

@cvinh
cvinh force-pushed the 18.0-add_pos_show_product_image branch from c667575 to 72a4107 Compare August 18, 2026 18:08
@OCA-git-bot OCA-git-bot added mod:pos_show_variant_image Module pos_show_variant_image and removed mod:pos_show_product_image Module pos_show_product_image labels Aug 18, 2026
@cvinh cvinh changed the title [18.0][ADD] pos_show_product_image: show product image in attribute popup [18.0][ADD] pos_show_variant_image: show product variant image in attribute popup Aug 18, 2026
@cvinh
cvinh force-pushed the 18.0-add_pos_show_product_image branch from 72a4107 to c683439 Compare August 18, 2026 18:12
@cvinh

cvinh commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

module renamed from pos_show_product_image to pos_show_variant_image --> better undestanding

@cvinh

cvinh commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

tests fail because of pos_user_restriction

… popup

The POS attribute selection popup (opened when a product has
attributes) never showed a product image, even though it already
resolves and displays the matching product.product variant.

This adds the image of the currently selected variant, updating
live as the cashier changes attribute values, reusing the existing
native product.product.getImageUrl() method.

Assisted-by: Claude (Anthropic)
@cvinh
cvinh force-pushed the 18.0-add_pos_show_product_image branch from fc58577 to 590130b Compare August 24, 2026 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:pos_show_variant_image Module pos_show_variant_image series:18.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants