Repository navigation
Conversation
cvinh
force-pushed
the
18.0-add_pos_show_product_image
branch
2 times, most recently
from
August 17, 2026 21:34
466a84a to
c667575
Compare
Contributor
Author
|
resolves #1251 (comment) |
cvinh
force-pushed
the
18.0-add_pos_show_product_image
branch
from
August 18, 2026 18:08
c667575 to
72a4107
Compare
cvinh
force-pushed
the
18.0-add_pos_show_product_image
branch
from
August 18, 2026 18:12
72a4107 to
c683439
Compare
Contributor
Author
|
module renamed from pos_show_product_image to pos_show_variant_image --> better undestanding |
Contributor
Author
|
tests fail because of pos_user_restriction |
cvinh
force-pushed
the
18.0-add_pos_show_product_image
branch
from
August 24, 2026 07:01
c683439 to
fc58577
Compare
… popup The POS attribute selection popup (opened when a product has attributes) never showed a product image, even though it already resolves and displays the matching product.product variant. This adds the image of the currently selected variant, updating live as the cashier changes attribute values, reusing the existing native product.product.getImageUrl() method. Assisted-by: Claude (Anthropic)
cvinh
force-pushed
the
18.0-add_pos_show_product_image
branch
from
August 24, 2026 07:17
fc58577 to
590130b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The POS attribute selection popup (opened when a product has attributes) never showed a product image, even though it already resolves and displays the matching product.product variant.
This adds the image of the currently selected variant, updating live as the cashier changes attribute values, reusing the existing native product.product.getImageUrl() method.
Assisted-by: Claude (Anthropic)