Repository navigation
[18.0][IMP] pos_sale_picking_keep: Keep sale pickings and/or POS pickings too - #1583
Open
carlos-lopez-tecnativa wants to merge 4 commits into
Open
carlos-lopez-tecnativa wants to merge 4 commits into
carlos-lopez-tecnativa wants to merge 4 commits into
Conversation
Contributor
|
Hi @pedrobaeza, |
OCA-git-bot
added
series:18.0
mod:pos_sale_picking_keep
|
IMHO, the behaviour change introduced by this module should be configurable. |
Member
|
Adding extra steps for me is an entry barrier that is not adding value in this case. If you ever have a case where you want different behaviors across PoS configs or companies, then you can complicate it, but is it a current real case? |
Member
|
@carlos-lopez-tecnativa can you squash a bit the commit history and include TT? |
carlos-lopez-tecnativa
force-pushed
the
18.0-imp-pos_sale_picking_keep-dro
branch
from
July 13, 2026 16:35
7827acd to
c8d7817
Compare
Author
Done |
pedrobaeza
approved these changes
Jul 15, 2026
victoralmau
approved these changes
Jul 20, 2026
…t pickings As in some cases, you want to mix in POS orders the payment of an existing sale and added products in the same POS order, you still want to keep both pickings linked to sale orders AND pos orders. This introduces the keep picking strategy that allows to choose per POS configuration the strategy that fits the best to your case.
With this module installed, the expected behavior should apply by default, without any special configuration. Therefore, we removed these settings. TT63397
carlos-lopez-tecnativa
force-pushed
the
18.0-imp-pos_sale_picking_keep-dro
branch
3 times, most recently
from
July 31, 2026 18:45
d07b0e8 to
f74fbf7
Compare
victoralmau
force-pushed
the
18.0-imp-pos_sale_picking_keep-dro
branch
3 times, most recently
from
August 3, 2026 15:52
26d8772 to
18b6769
Compare
carlos-lopez-tecnativa
force-pushed
the
18.0-imp-pos_sale_picking_keep-dro
branch
from
August 3, 2026 18:34
18b6769 to
d2670d2
Compare
- The tag must be set on the test class, not on the common base class. - Add step_delay to start_pos_tour to prevent non-deterministic tests with other modules
victoralmau
force-pushed
the
18.0-imp-pos_sale_picking_keep-dro
branch
from
August 4, 2026 08:08
d2670d2 to
583fe7c
Compare
Contributor
|
This PR has the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the configuration and related files. With this module installed, the expected behavior should apply by default, without any special configuration. Therefore, we removed these settings.
Supersedes #1545
TT63602
@Tecnativa @victoralmau @pedrobaeza @rousseldenis could you please review this?