Repository navigation
[19.0][MIG] pos_product_multi_barcode: Migration to 19.0 - #1579
arielbarreiros96 wants to merge 20 commits into
Conversation
…roducts by multiple barcodes in search bar of POS.
Currently translated at 100.0% (3 of 3 strings) Translation: pos-16.0/pos-16.0-pos_product_multi_barcode Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_product_multi_barcode/it/
If a `barcode` is already in `product_by_barcode`, do not override it, as Odoo does with `product_by_id`. This can lead to incoherent data if something changes after product is first loaded and then reloads (if limited loading is enabled), or it is modified in `product_by_id` and not in `product_by_barcode`.
[DON'T MERGE] test-requirements.txt
OCA-git-bot
added
series:19.0
mod:pos_product_multi_barcode
004f955 to
2234174
Compare
2234174 to
69fea4e
Compare
|
@arielbarreiros96 Thanks for this migration, we're running it on a 19.0 project. One thing I've added on our side: a tour test that scans a product's main barcode and then its additional ones, asserting they all land on the same order line. The existing tests only cover barcodes_json server-side, so nothing currently demonstrates the module's actual purpose, and with the JS patch removed the tour fails at the second scan, so it does catch regressions. Happy to push it to your branch, or to open a follow-up PR once this merges, whichever you prefer. Note this is blocked on stock-logistics-barcode#723, which we've also offered to take over. |
Hello @DaanMarchal, I think the extra tests can be added as an extra [IMP] PR, since to allow the migration itself to be independent a little more independent. In relation to #723 it seems basically approved, and waiting just for merge |
Standard migration to v19
Depends on: