Repository navigation
🎨 Palette: [UX improvement] Dynamic accessibility labels for list removal actions - #202
Conversation
Adds dynamic context to the `.help()` and `.accessibilityLabel()` modifiers on removal buttons in linked app and linked controller lists. VoiceOver users can now hear exactly which item is being removed instead of repeated generic "Remove" announcements. Co-authored-by: NSEvent <44446865+NSEvent@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
💡 What
Added dynamic string interpolation to the
.help()and.accessibilityLabel()modifiers for the "Remove" trash buttons inLinkedAppsSheet,LayerLinkedAppsSheet, andLinkedControllersSheet.🎯 Why
When dealing with lists of apps or controllers, having a static "Remove" label makes it extremely difficult for screen reader users to identify which row their focus is currently on. Using dynamic context strings like
Remove Safariprovides immediate clarity.♿ Accessibility
This directly improves the VoiceOver experience by providing explicit context for destructive actions within lists.
PR created automatically by Jules for task 14777248484762260415 started by @NSEvent
Summary by CodeRabbit