Skip to content

🎨 Palette: [UX improvement] Dynamic accessibility labels for list removal actions - #202

Merged
NSEvent merged 1 commit into
mainfrom
palette-dynamic-list-actions-a11y-14777248484762260415
Oct 15, 2026
Merged

NSEvent merged 1 commit into
mainfrom
palette-dynamic-list-actions-a11y-14777248484762260415

Conversation

@NSEvent

@NSEvent NSEvent commented Oct 15, 2026 •

Copy link
Copy Markdown
Owner

💡 What

Added dynamic string interpolation to the .help() and .accessibilityLabel() modifiers for the "Remove" trash buttons in LinkedAppsSheet, LayerLinkedAppsSheet, and LinkedControllersSheet.

🎯 Why

When dealing with lists of apps or controllers, having a static "Remove" label makes it extremely difficult for screen reader users to identify which row their focus is currently on. Using dynamic context strings like Remove Safari provides immediate clarity.

♿ Accessibility

This directly improves the VoiceOver experience by providing explicit context for destructive actions within lists.


PR created automatically by Jules for task 14777248484762260415 started by @NSEvent

Summary by CodeRabbit

  • Accessibility
    • Removal buttons for linked apps and controllers now identify the specific item in their help text and accessibility labels.

Adds dynamic context to the `.help()` and `.accessibilityLabel()` modifiers on removal buttons in linked app and linked controller lists. VoiceOver users can now hear exactly which item is being removed instead of repeated generic "Remove" announcements.

Co-authored-by: NSEvent <44446865+NSEvent@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b16bff40-2c92-4467-a4ac-da50b01736e9
📥 Commits

Reviewing files that changed from the base of the PR and between ee12c4b and 0543f5e.

📒 Files selected for processing: 4
  • .Jules/palette.md
  • XboxControllerMapper/XboxControllerMapper/Views/MainWindow/LayerLinkedAppsSheet.swift
  • XboxControllerMapper/XboxControllerMapper/Views/MainWindow/LinkedAppsSheet.swift
  • XboxControllerMapper/XboxControllerMapper/Views/MainWindow/LinkedControllersSheet.swift

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

📝 Walkthrough

Removal buttons in linked-app and linked-controller sheets now identify the item in their help text and accessibility labels. App labels use the display name when available and otherwise use the bundle identifier. A palette entry documents the labeling rule.

Changes: Linked item removal labels

Layer / File(s) Summary
Add linked-item context to removal labels
XboxControllerMapper/XboxControllerMapper/Views/MainWindow/LayerLinkedAppsSheet.swift, XboxControllerMapper/XboxControllerMapper/Views/MainWindow/LinkedAppsSheet.swift, XboxControllerMapper/XboxControllerMapper/Views/MainWindow/LinkedControllersSheet.swift, .Jules/palette.md
The linked-app buttons use the app display name or bundle identifier in their help text and accessibility labels. The linked-controller button uses the controller display name. The palette entry documents the rule for list actions.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 0543f

Removal labels now identify the linked app or controller. No material PR-introduced risk remains, so the change is ready to merge subject to normal checks.

Pre-merge checks: Passed 5
Passed Passed checks: 5 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the main change: adding dynamic, item-specific accessibility labels for list removal actions. It is concise and directly related to the pull request.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@NSEvent
NSEvent merged commit 9b2b5d1 into main Oct 15, 2026
2 checks passed
@NSEvent
NSEvent deleted the palette-dynamic-list-actions-a11y-14777248484762260415 branch October 15, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant