Repository navigation
test(regression): prove owners' live events show publicly (#347 traces) - #381
Merged
Merged
Conversation
…ity page and Explore Extends the owner event visibility spec so a signed-out visitor checks the community page and Explore's community sheet: published and approved-import events are listed, while drafts, a still-hidden import, scheduled, cancelled and removed events are not. The visitor steps now run on the traced page, so the Playwright trace shows them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #347: the "Done when" line asking for a passing Playwright trace for each owner pathway.
Three of the four pathways already had a spec on
mainthat proves them end to end, so this PR doesn't add duplicates. The one gap was events showing publicly.owner-event-visibility.spec.tschecked the owner's Events tab badges and that a visitor could open a live event's page. It never checked the public community page or Explore's list. This PR extends that spec rather than adding a new one.What changed
owner-event-visibility.spec.ts, first test, after the owner fixes their events:/n/<slug>, the public community page./explore?node=<id>, Explore's community sheet.No app code changes, so no changeset.
Pathways
All run on the
start:ssrstack (deployment image +bun run test:db:uptest databases),trace: "on", at ea8c913: 11 passed (1.6m).owner-event-visibility.spec.ts(extended here)community-map-status.spec.ts(unchanged)event-station.spec.ts(unchanged)organizer-stations.spec.ts(unchanged)admin-joins.spec.ts(unchanged)The join pathway is already covered by
onboarding.spec.ts/onboarding-join.spec.ts, so I didn't rerun it here.Why the unchanged specs are enough:
How to run
bun run test:db:up REGRESSION_MODE=start:ssr bunx playwright test -c tests/regression/browser/playwright.config.mjs --project=start:ssr specs/owner-event-visibility.spec.ts specs/community-map-status.spec.ts specs/event-station.spec.ts specs/organizer-stations.spec.ts specs/admin-joins.spec.tsOn a cold Docker cache the image build can outlast Playwright's 120s web-server timeout. Boot
bun tests/regression/lib/start-container.mjs ssronce to warm it, stop it, then run the command again.biome checkis clean on the changed file. Trace zips are kept locally, not committed. Captures from the trace viewer are below.