Generate Preview link responses and runtime metadata - #3366
Draft
karim-alweheshy wants to merge 3 commits into
Draft
karim-alweheshy wants to merge 3 commits into
karim-alweheshy wants to merge 3 commits into
Conversation
added 3 commits
September 23, 2026 20:59
Signed-off-by: Karim Alweheshy <karim.alweheshy@reddit.com>
Signed-off-by: Karim Alweheshy <karim.alweheshy@reddit.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Native target linking needs response files and runtime-policy metadata derived from prepared dependencies.
Scope
Generate static-library Preview link responses and runtime metadata using artifact discovery and dependency output groups. Public activation remains separate.
Dependency and landing boundary
This draft uses an integration-only diff base,
preview-review-base-link-metadata, combiningpreview-review-09-link-policy,preview-review-10-link-artifacts,preview-review-11-output-groups.Do not merge this PR into the integration base. Its prerequisites must land on
mainfirst; then retarget/reconcile this branch ontomainand rerun validation. The temporary base keeps prerequisite code out of this review diff.Validation
Validated the propagated PR candidate
7ee20d7f5222d0a1b33e343d42df03c0ddc04801against its updatedintegration diff base
c87802fa9da195aab2fe085af055bc7af48250e2using Bazel 9.2.0 andDEVELOPER_DIR=/Applications/Xcode.app/Contents/Developer.c87802fa9da195aab2fe085af055bc7af48250e2: root tests plus generateddocumentation passed, 117/117; 0 executed, all test results cached.
7ee20d7f5222d0a1b33e343d42df03c0ddc04801against basec87802fa9da195aab2fe085af055bc7af48250e2: root testsplus generated documentation passed, 125/125; 0 executed, all test results
cached (
--jobs=2).points.
DEVELOPER_DIR=/Applications/Xcode.app/Contents/Developer USE_BAZEL_VERSION=9.2.0 bazel --bazelrc=bazel_9.bazelrc --nosystem_rc --nohome_rc test --jobs=2 --test_summary=terse //... //docs:diff_test DEVELOPER_DIR=/Applications/Xcode.app/Contents/Developer USE_BAZEL_VERSION=9.2.0 bazel --bazelrc=bazel_9.bazelrc --nosystem_rc --nohome_rc run //:buildifier.checkTesting and limitations
Regression tests accompany the changed behavior. Rerun the commands above on the stated base. These results validate this exact split, not arbitrary cherry-picks or a fresh Xcode Canvas render. Hosted CI is pending at publication. This PR alone is not a claim of complete native Preview support; end-to-end Canvas validation belongs to the assembled activation branch.