Skip to content

Prepare Preview dependencies without selected products - #3365

Draft
karim-alweheshy wants to merge 2 commits into
preview-review-06-swift-importsfrom
preview-review-11-output-groups
Draft

karim-alweheshy wants to merge 2 commits into
preview-review-06-swift-importsfrom
preview-review-11-output-groups

Conversation

@karim-alweheshy

@karim-alweheshy karim-alweheshy commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Why

Preparing native compiler/linker dependencies must not require rebuilding the selected Bazel product.

Scope

Add dedicated framework/import and link-input output groups for ordinary and mixed-language targets. Test lazy materialization and archived frameworks.

Dependency and landing boundary

Depends on preview-review-06-swift-imports. Review only the diff against that base. Land the prerequisite first, then retarget/reconcile onto main and rerun validation; do not merge this PR into the feature branch.

Validation

Validated head 56416da0d924665cdbbd336c710e2eb92506afc4 against base 6e5981874fc082457d78ab96180d1d08f4ce07eb on macOS 26.7, Xcode 27.0 (27A266a), Bazel 9.2.0.

  • Root tests plus generated documentation: 108/108 passed (1 executed, 107 cached).
  • Repository Buildifier and whitespace checks passed.
DEVELOPER_DIR=/Applications/Xcode.app/Contents/Developer USE_BAZEL_VERSION=9.2.0 bazel --bazelrc=bazel_9.bazelrc --nosystem_rc --nohome_rc test --jobs=4 --test_summary=terse //... //docs:diff_test
DEVELOPER_DIR=/Applications/Xcode.app/Contents/Developer USE_BAZEL_VERSION=9.2.0 bazel --bazelrc=bazel_9.bazelrc --nosystem_rc --nohome_rc run //:buildifier.check

Testing and limitations

Regression tests accompany the changed behavior. Rerun the commands above on the stated base. These results validate this exact split, not arbitrary cherry-picks or a fresh Xcode Canvas render. Hosted CI is pending at publication. This PR alone is not a claim of complete native Preview support; end-to-end Canvas validation belongs to the assembled activation branch.

Karim Alweheshy added 2 commits September 23, 2026 20:58
Add explicit framework/import and link-input output groups for ordinary and mixed target IDs. Make metadata generation independent of expensive link artifacts and omit the selected product when preparing native Preview dependencies. Test archived frameworks and lazy output-group reachability.

Signed-off-by: Karim Alweheshy <karim.alweheshy@reddit.com>
@karim-alweheshy
karim-alweheshy requested a review from a team October 1, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant