MDEV-40750 gcc-16.1.0 on ppc64 causes innodb to fail to compile - #5546
Merged
Conversation
dr-m
reviewed
Aug 13, 2026
Contributor
There was a problem hiding this comment.
Based on my experiment, it seems that both #if predicates had better be changed to one of the following:
# if (__GNUC__ >= 11 && __GNUC__ < 16) || (defined __clang_major__ && __clang_major__ >= 18)
We can revisit this if the build starts to fail on clang.
Member
Author
There was a problem hiding this comment.
clang 21 seems fine. I'll recheck again on the gcc define versions.
gkodinov
added
the
MariaDB Foundation
Assembler comes up with the error: unrecognized opcode: `dcbstps' dcbstps is a Power 10 instruction. The default target arch on most platforms is Power 8 or 9. Added the target power10 to the function pmem_phwsync. The execution of this function is gated on the ISA 3.1 in pmem_persist_init so there's no chance of a SIGILL. clang supports this target as arch=pwr10 and gcc as cpu=power10. Revert back to using opcodes for old versions.
dr-m
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assembler comes up with the error:
unrecognized opcode: `dcbstps'
dcbstps is a Power 10 instruction. The default target arch on most platforms is Power 8 or 9.
Added the target power10 to the function pmem_phwsync. The execution of this function is gated on the ISA 3.1 in pmem_persist_init so there's no chance of a SIGILL.
Before and after on sid container on ppc64le: