MDEV-40749 period.create test leaks/faults in asan - #5545
Merged
Conversation
Selecting from the information_schema.plugins causes the loading of all plugins. Because rockdb leaks, and duckdb triggers an address sanitizer warning on shutdown avoid this table. Use the information_schema.ENGINES to validate that InnoDB is disabled per the original request in the review of MDEV-32205.
gkodinov
added
the
MariaDB Foundation
There was a problem hiding this comment.
Pull request overview
This PR updates the period.create MTR test to avoid querying information_schema.all_plugins, which can force loading all plugins and trigger ASAN-relevant leaks/warnings (e.g., RockDB leak, DuckDB shutdown warning). It instead validates the “InnoDB disabled” condition via information_schema.ENGINES, aligning with the intent from the earlier MDEV-32205 review context.
Changes:
- Replace
information_schema.all_pluginsquery withinformation_schema.enginesto check InnoDB support state. - Update the expected
.resultoutput accordingly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| mysql-test/suite/period/t/create.test | Switches the InnoDB-disabled verification query to information_schema.ENGINES to avoid loading all plugins. |
| mysql-test/suite/period/r/create.result | Updates expected output for the new ENGINES.SUPPORT query. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| @@ -113,7 +113,7 @@ drop table t2; | |||
| --echo # Make sure innodb id disabled, but there's at least one innodb table | |||
FooBarrior
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selecting from the information_schema.plugins causes the loading of all plugins. Because rockdb leaks, and duckdb triggers an address sanitizer warning on shutdown avoid this table.
Use the information_schema.ENGINES to validate that InnoDB is disabled per the original request in the review of MDEV-32205.