Fix bugs in String.fromCString and Char.scan - #659
Merged
Merged
Conversation
The implementation of `String.fromCString` did not confirm that at least a single C-string character could be consumed from the input string and would return `SOME ""` on an input string whose first character could not be converted (e.g., illegal escape). Closes MLton#658 Also, unify the implementations of `String.fromString` and `String.fromCString` to share the logic for converting an initial character and converting the remaining characters.
The Basis Library specification for `Char.scan` states: "As the table indicates, escaped formatting sequences (`\f...f\`) are passed over during scanning. Such sequences are successfully scanned, so that the remaining stream returned by scan will never have a valid escaped formatting sequence as its prefix." `Char.scan` ran `skipFormatSequences` on the state after the successful scan of a non-escape character, but did not on the state after the successful scan of a non-escaped-formatting-sequence escape sequence.
…String conversions
MatthewFluet
force-pushed
the
text-scan-bugs
branch
from
September 30, 2026 12:18
4a1a844 to
95049a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.