Conversation
Prevent Voxy from crashing the game when the DataFixer fails while recovering an invalid or incompatible blockstate. On Minecraft 1.21.1, DataFixer can throw an `IllegalArgumentException` during the `BLOCK_STATE` update, for example when a required type is missing from the registry: ```text java.lang.IllegalArgumentException: Unknown type: block_state ``` This exception bypasses the `DataResult` error handling used by the BlockState codec and can therefore crash the game. The DataFixer update is now wrapped in exception handling, falling back to the original blockstate decode result when the update fails. If the blockstate remains invalid, Voxy continues with its normal behavior, using air for the affected entry instead of propagating the exception. This keeps corrupted or incompatible blockstate data from crashing Voxy during recovery.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent Voxy from crashing the game when the DataFixer fails while recovering an invalid or incompatible blockstate.
On Minecraft 1.21.1, DataFixer can throw an
IllegalArgumentExceptionduring theBLOCK_STATEupdate, for example when a required type is missing from the registry:This exception bypasses the
DataResulterror handling used by the BlockState codec and can therefore crash the game.The DataFixer update is now wrapped in exception handling, falling back to the original blockstate decode result when the update fails. If the blockstate remains invalid, Voxy continues with its normal behavior, using air for the affected entry instead of propagating the exception.
This keeps corrupted or incompatible blockstate data from crashing Voxy during recovery.