Repository navigation
feat(robotics): fence controller submissions by epoch - #2875
Draft
Tristan-Stoltz-ERC wants to merge 8 commits into
Draft
Tristan-Stoltz-ERC wants to merge 8 commits into
Tristan-Stoltz-ERC wants to merge 8 commits into
Conversation
This was referenced Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #2874. Adds an in-process reference controller-sink wrapper that requires a controller epoch on every submission and distinguishes command admission from later outcome ingestion.
Implementation
EpochFencedControllerSink<S>, which deliberately does not implement the untaggedControllerSinktrait; callers must name the generation for each submission.EpochFencedControllerReceiptcarrying both the epoch and native controller receipt, so the epoch remains part of the effective ticket/request identity.docs/research/ROBOTICS_EPOCH_FENCED_COMMAND_ADMISSION_V0_1.mddocumenting the in-process scope and the production atomic-admission requirement.stale_epoch_command_admission_acceptances, kept separate from stale outcome-event acceptance and included in the hard-gate violation total.Critical limits
This is an in-process reference fence, not a production hardware or IPC admission implementation. The caller must hold one owner/mutex around generation advancement and submission. It does not consult the persistent authority on every call, prevent another process from bypassing the wrapper, or cancel commands already accepted in an older generation. A real native sink must enforce the epoch at its atomic command-acceptance/application boundary; hardware watchdog/e-stop/safe-state logic remains independent.
Validation
Related: #2828, #2836, #2852, #2860, #2862, #2868, #2874.