Repository navigation
Point PermissionFlow at upstream and select Xcode 26.3 in CI #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
f4e678b
37d1caa
e251917
e8dcbfe
6123d4c
33d4435
b80ac21
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,16 +15,16 @@ env: | |
|
|
||
| jobs: | ||
| build: | ||
| runs-on: macos-15 | ||
| runs-on: macos-26 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When a Useful? React with 👍 / 👎. |
||
| outputs: | ||
| sparkle_enabled: ${{ steps.sparkle_settings.outputs.enabled }} | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Select Xcode 16 (Swift 6 for DMGMaker, 6.1 for PermissionFlow) | ||
| - name: Select Xcode 26.3 (PermissionFlow needs swift-tools-version 6.2) | ||
| uses: maxim-lobanov/setup-xcode@v1 | ||
| with: | ||
| xcode-version: '16' | ||
| xcode-version: '26.3' | ||
|
|
||
| - name: Determine Sparkle publishing settings | ||
| id: sparkle_settings | ||
|
|
@@ -49,7 +49,7 @@ jobs: | |
| - name: Build release | ||
| run: | | ||
| xcodebuild -scheme Aware -configuration Release -derivedDataPath build \ | ||
| build -quiet | ||
| ARCHS="arm64 x86_64" ONLY_ACTIVE_ARCH=NO build -quiet | ||
|
|
||
| - name: Create DMG with DMGMaker | ||
| run: | | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -49,4 +49,15 @@ Repo-agnostic skills (`sharpen-the-tip`, `prototype-mode`, `housekeeping`, `proa | |
|
|
||
| - Before reporting a commit as missing required provenance fields, verify against the exact commit messages as they exist on GitHub. If the fields are present, do not claim they are missing. | ||
| - The provenance contract is defined in `records/REPO.md` and enforced by `scripts/new-commit-message.sh`. Cite the specific field that is missing and the rule it violates; do not review commits against an assumed format. | ||
| <!-- template-managed:end --> | ||
| <!-- template-managed:end --> | ||
|
|
||
| ## Local Divergence | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Move this local-divergence block after the Useful? React with 👍 / 👎. |
||
|
|
||
| - Build verification: `xcodebuild -scheme Aware -configuration Debug -derivedDataPath build build` | ||
| - PermissionFlow comes from upstream jaywcjlove/PermissionFlow, pinned to v2.11.2, and requires Xcode 26+ to resolve (its manifest uses `swift-tools-version: 6.2`). The old LPFchan/PermissionFlow fork exists for reference: it carried a `@Sendable` fix in `SettingsNavigator` without which apps built with Xcode 16's SDK crash opening System Settings. If the build ever drops back to Xcode 16, restore the fork or re-apply that fix. | ||
| - Commit provenance setup: `scripts/install-hooks.sh` configures the tracked `commit-msg` hook locally. | ||
| - Commit provenance checks: `scripts/check-commit-standards.sh <commit-message-file>` and `scripts/check-commit-range.sh <base> <head>` | ||
| - There is no dedicated automated test suite in the repo today. For runtime changes, use the build plus focused manual validation. | ||
| - Preserve the product and workflow constraints in `records/SPEC.md`: menu bar-only UX, local presence detection, no telemetry or analytics, and safe failure when camera access is denied or unavailable. | ||
| - `AWARE-AGENT-PROMPT.md` is a legacy bootstrap helper. Do not treat it as a second policy layer. | ||
| - `upstream-intake/` is omitted in Aware because the repo does not currently track upstream review. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -359,10 +359,10 @@ | |
| }; | ||
| F5A6B7C80001 /* XCRemoteSwiftPackageReference "PermissionFlow" */ = { | ||
| isa = XCRemoteSwiftPackageReference; | ||
| repositoryURL = "https://github.com/LPFchan/PermissionFlow"; | ||
| repositoryURL = "https://github.com/jaywcjlove/PermissionFlow"; | ||
| requirement = { | ||
| kind = exactVersion; | ||
| version = "2.11.2-swift6.1.1"; | ||
| version = "2.11.2"; | ||
|
Comment on lines
+362
to
+365
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When this switches the package to upstream v2.11.2, the canonical AGENTS.md reference: AGENTS.md:L50-L50 Useful? React with 👍 / 👎. |
||
| }; | ||
| }; | ||
| /* End XCRemoteSwiftPackageReference section */ | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked all three changed workflows: each still uses
macos-15, but Xcode 26.3 requires macOS Tahoe and is absent from the macOS 15 runner inventory. Thesetup-xcodeaction only selects an installed matching version, so the build, release, and appcast jobs will fail during setup before running their scripts; move these jobs to a compatible macOS runner while retaining the repository's Xcode 26+ requirement.AGENTS.md reference: AGENTS.md:L50-L50
Useful? React with 👍 / 👎.