Repository navigation
Adopt PermissionFlow for the camera permission - #1
Conversation
timestamp: 2026-09-26 17-20-42 KST changes: - Add Swift package PermissionFlow (github.com/jaywcjlove/PermissionFlow, from 2.11.2) to Aware.xcodeproj with products PermissionFlow and PermissionFlowCameraStatus, and pin v2.11.2 in Package.resolved - MenuBarController registers the camera status provider, routes the notDetermined system prompt through PermissionFlow's CameraPermissionStatusProvider, and opens the System Settings camera pane via PermissionFlowController.authorize(pane: .camera) after the existing denial alert - AGENTS.md Local Divergence notes the new SwiftPM >= 6.2 (Xcode 26+) build requirement rationale: - Replace hand-rolled camera permission request/settings code paths with PermissionFlow, which reports status and opens the correct privacy pane; camera has no drag panel, so only pane opening and status/request APIs are used - Alert wording, menu UX, and localization stay unchanged; the system prompt is preserved via the provider's requestAuthorization checks: - Verification build of an identical tree against a local v2.11.2 mirror (only swift-tools-version lowered) succeeded; the real pin needs SwiftPM >= 6.2 (Xcode 26) to resolve, newer than this machine's Xcode 16.3 project: aware agent: kimi-code role: worker commit: LOG-20260926-172042-micode
timestamp: 2026-09-26 17-40-16 KST changes: - PermissionFlow now comes from LPFchan/PermissionFlow at exact version 2.11.2-swift6.1 (upstream v2.11.2 with swift-tools-version 6.1); Package.resolved re-resolved - AGENTS.md Local Divergence note updated to match rationale: - every upstream PermissionFlow tag declares swift-tools-version 6.2, which needs Xcode 26; this machine and the repo's tooling are on Xcode 16.3 checks: - xcodebuild resolved the fork tag and built the Aware scheme (Debug) on Xcode 16.3 project: aware agent: claude-code role: worker commit: LOG-20260926-174016-decode
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ba4e081b16
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
timestamp: 2026-09-26 17-48-59 KST changes: - build, release and publish-appcast macOS jobs run on macos-15 and select Xcode 16 (latest 16.x, Swift 6.1+) via setup-xcode rationale: - Codex review on #1: the PermissionFlow fork declares swift-tools-version 6.1, which macos-14's Xcode can't resolve; the PR's Build run failed on it checks: - the PR's Build workflow reruns on this push project: aware agent: claude-code role: worker commit: LOG-20260926-174859-decode
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Camera permission now goes through PermissionFlow: status via
PermissionFlowCameraStatus, the system prompt when undetermined, andauthorize(pane: .camera)to open Privacy & Security → Camera when denied. Existing alert copy and behavior are unchanged;PresenceDetectorkeeps its own capture guard.The package comes from the LPFchan/PermissionFlow fork at
2.11.2-swift6.1(upstream 2.11.2 with swift-tools-version lowered to 6.1) so it builds on Xcode 16.3.Checks: resolved and built the Aware scheme (Debug) on Xcode 16.3. The permission flow itself hasn't been exercised by hand.
Implementation by a Kimi Code subagent, reviewed and repointed to the fork by Claude Code.