Skip to content

Lacking documentation for MeteoLowFreq #843

Closed

Description

@lior-antonov

The documentation for MeteoLowFreq toolkit is partially wrong(some methods dont exist) and is very lacking.

Activity

  1. ilayfalach commented on Sep 15, 2026

    @ilayfalach
    Collaborator

    Rewritten on local branch ISSUE843 (commits d2ab600a, 1474e02d).

    Checked every name on the page against hera/measurements/meteorology/lowfreqdata/. Four things were wrong:

    • plotSeasonalHourly does not exist anywhere in the package.
    • calcHourlyDist takes Field (capital F) and normalization, not field and density.
    • plotProbContourf_bySeason takes plotField, a single column name, not fields=[...].
    • dateLinePlot, plotProbContourf and resampleSecondMoments were not documented at all.

    The page now follows the structure of the sibling MeteoHighFreq page: data source format and docType, initialisation, all three analysis methods (with the exact columns addDatesColumns adds and the three valid normalization values), and all four plotting methods grouped by the dailyPlots / seasonalPlots accessor they hang off. It also records that the toolkit constant MeteoLowFreq and the database toolkit name lowFreqMeteorology differ, which the old page did not mention.

    hera/tests/unit/test_lowfreq_docs_match_code.py parses the Python examples out of the page and resolves every lf.<accessor>.<method>(...) call and keyword argument against the real classes, so this cannot drift again silently. Against the old page it fails with exactly the four errors above.

    Separate commit, unrelated to the docs: presenation.__init__, Plots.__init__, SeasonalPlots.__init__ and DailyPlots.__init__ each printed emoji debug lines, so every getToolkit(METEOROLOGY_LOWFREQ) wrote seven lines to stdout. Removed.

  2. ilayfalach commented on Sep 15, 2026

    @ilayfalach
    Collaborator

    PR #1078 opened.

  3. added a commit that references this issue on Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions