Repository navigation
feat(sync): say on the Remote access screen when its settings come from a newer PlayGuard - #547
Merged
Merged
Conversation
…om a newer PlayGuard sync.conf and link.conf written by a newer version are read as far as understood and never written over; the status line now says so in the 15 languages instead of only failing at the next save.
🕹️ Preview of this pull requestNo longer online (last commit |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes, and why
A
sync.conforlink.confwritten by a newer PlayGuard is read as far as understood and never written over, but the user only learned it from an English error at the next save. The Remote access status line now says it (amber), in the 15 catalogues, anddocs/config.mdmentions it. Squash merge.How it was verified
make test(new cases insync_files: newersync.conf, newerlink.conf, back to normal),check_resources.py,check_sources.py. Not run on a console; no desktop smoke: the screen is unchanged unless a newer file is present.Screens: none
Checklist
make testandpython3 tools/check_resources.py .passresources/i18n/*/playguard.json(English is fine as a placeholder)Screens:line abovedocs/), in English and French (docs/fr/):docs/config.mdonly, which has no French page