Repository navigation
fix(dialog, date-range-picker): sync the dialog on reconnect and commit after igcClosing - #2577
Merged
Merged
Conversation
…it after igcClosing - Dialog: a dialog that moves, or is removed and appended again, keeps its state. A close also reaches the native dialog while the host is out of the document, and an append makes an open dialog modal again. - Date range picker: Done, Cancel, Escape and an outside click emit igcClosing first and commit or restore the range only when the close goes on. Done now emits igcChange after igcClosing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Checklist
CHANGELOG.mdentry under[Unrelease]