Fix crash with HXCPP_CATCH_SEGV on android x86_64 - #1378
Merged
Aidan63 merged 4 commits intoSep 8, 2026
Conversation
tobil4sk
force-pushed
the
fix/android-x86_64-signal
branch
2 times, most recently
from
August 27, 2026 23:55
72240c5 to
4d6603f
Compare
This compat code was added in c91637a to work around an ndk compatibility issue when linking files that target platform 21 with older object files. 64 bit architectures (arm64 and x86_64) have only ever been supported with platform 21 and above, so this fix should be excluded from there. Keeping it enabled results in an error on x86_64 android builds that define HXCPP_CATCH_SEGV, because bsd_signal does not exist, so when hxcpp attempts to call signal there is a crash with the message: "bsd_signal symbol not found!" Checking HXCPP_M64 instead of just HXCPP_ARM64 ensures that all 64-bit architectures are covered: https://github.com/HaxeFoundation/hxcpp/blob/10f73c52cb4c82e72df20d012216b1592eff8d28/toolchain/common-defines.xml#L8
These became obsolete in 76e4f4e, but some were left in.
The patch is not needed in ndk r13 and above, as the bsd_signal symbol was restored: https://android-review.googlesource.com/c/platform/development/+/255054
tobil4sk
force-pushed
the
fix/android-x86_64-signal
branch
from
September 5, 2026 09:34
4d6603f to
74514fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This compat code was added in c91637a to work around an ndk compatibility issue when linking files that target platform 21 with older object files.
64 bit architectures (arm64 and x86_64) have only ever been supported with platform 21 and above, so this fix should be excluded from there. Keeping it enabled results in an error on x86_64 android builds that define HXCPP_CATCH_SEGV, because bsd_signal does not exist, so when hxcpp attempts to call signal there is a crash with the message:
"bsd_signal symbol not found!"Checking HXCPP_M64 instead of just HXCPP_ARM64 ensures that all 64-bit architectures are covered:
hxcpp/toolchain/common-defines.xml
Line 8 in 10f73c5