Repository navigation
Skip PHP files without a services marker in the services definition index - #2925
Merged
Haehnchen merged 1 commit intoNov 15, 2026
Merged
Conversation
…ndex `ServicesDefinitionStubIndex` ran its path validation and the service lookup (control flow of every namespace and every class method) on every PHP file. A PHP file can only define services through a `services` array key or a `ContainerConfigurator` parameter, so it must contain `services` or `Configurator`. The index now returns early otherwise, before the path validation. XML and YAML files are unaffected, and a new test covers a plain PHP array config file that never mentions `Configurator`. On ux.symfony.com (11,295 PHP files), the index takes 103-115 ms per indexing pass instead of 244-270 ms, with identical output for every file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ServicesDefinitionStubIndexran its path validation and the service lookup (control flow of every namespace and every class method) on every PHP file. A PHP file can only define services through aservicesarray key or aContainerConfiguratorparameter, so it must containservicesorConfigurator.The index now returns early otherwise, before the path validation. XML and YAML files are unaffected, and a new test covers a plain PHP array config file that never mentions
Configurator.On ux.symfony.com (11,295 PHP files), the index takes 103-115 ms per indexing pass instead of 244-270 ms, with identical output for every file.