Repository navigation
Use StringSearcher for the text pre-filters of the config and UX CSS indexes - #2923
Merged
Haehnchen merged 1 commit intoNov 14, 2026
Merged
Conversation
…S indexes `ConfigStubIndex` and `UxCssConfigStubIndex` already skip PHP files without `twig_component` or `ux_css`, but they check with `StringUtil.contains`, which compares char by char at every position. `StringSearcher`, bundled with the platform, skips ahead by the pattern length and gives the same answer. On ux.symfony.com (11,295 PHP files), `config_stub_index` drops from 236-385 ms to 54-58 ms per indexing pass and `ux_css_config` from 215-386 ms to 91-98 ms, with identical output.
Owner
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConfigStubIndexandUxCssConfigStubIndexalready skip PHP files withouttwig_componentorux_css, but they check withStringUtil.contains, which compares char by char at every position.StringSearcher, bundled with the platform, skips ahead by the pattern length and gives the same answer.On ux.symfony.com (11,295 PHP files),
config_stub_indexdrops from 236-385 ms to 54-58 ms per indexing pass andux_css_configfrom 215-386 ms to 91-98 ms, with identical output.