Repository navigation
Skip PHP files without routes in the routes index - #2920
Merged
Merged
Conversation
For PHP files, `RoutesStubIndex` visits every class and walks the whole PSI tree looking for `RoutingConfigurator` closures. It is the most expensive index of the plugin. It now returns early, using `StringSearcher`, unless the content contains `RoutingConfigurator` or `route` in any case. The match is case-insensitive because `Route` annotations and attributes are matched case-insensitively. Two new tests cover a fluent file that never mentions `route` and an upper-case `ROUTE` attribute. On ux.symfony.com (11,295 PHP files), the index takes 316-335 ms per indexing pass instead of 1,246-1,493 ms, with identical output for every file.
Owner
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For PHP files,
RoutesStubIndexvisits every class and walks the whole PSI tree looking forRoutingConfiguratorclosures. It is the most expensive index of the plugin.It now returns early, using
StringSearcher, unless the content containsRoutingConfiguratororroutein any case. The match is case-insensitive becauseRouteannotations and attributes are matched case-insensitively.Two new tests cover a fluent file that never mentions
routeand an upper-caseROUTEattribute. On ux.symfony.com (11,295 PHP files), the index takes 316-335 ms per indexing pass instead of 1,246-1,493 ms, with identical output for every file.