Repository navigation
Harden h5repack - #6670
Merged
Merged
Harden h5repack#6670
Conversation
Contributor
Review ChecklistThis PR touches the following areas. Each needs a sign-off
|
bmribler
force-pushed
the
fix_GHSA-gxw2-rpgf-4vp8
branch
from
September 13, 2026 18:08
8b30ba4 to
9f58991
Compare
Fix double free (GHSA-gxw2-rpgf-4vp8) and memory leaks
Remove warnings
- subscript of a pointer to void is a GNU extension [-Wpointer-arith]
- ISO C forbids taking the address of an expression of type 'void' [-Wpedantic]
bmribler
force-pushed
the
fix_GHSA-gxw2-rpgf-4vp8
branch
from
September 13, 2026 18:40
9f58991 to
4c8f64a
Compare
| int k; | ||
| named_dt_t *named_dt_head = NULL; /* Pointer to the stack of named datatypes copied */ | ||
| void *buf = NULL; | ||
| void *refbuf = NULL; |
Collaborator
There was a problem hiding this comment.
Using void * here is a bit unnecessary and both introduces the potential for type safety problems and then requires some (ugly, IMO) casts later on. This could probably use a little refactoring either to separate the reference types or just use separate sets of variables.
jhendersonHDF
approved these changes
Sep 28, 2026
Contributor
|
🎉 All checklist items are signed off — @bmribler, this PR is ready to merge. |
github-actions
Bot
added
the
checklist-complete
bmribler
marked this pull request as draft
October 1, 2026 06:51
bmribler
marked this pull request as ready for review
October 2, 2026 20:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.