Repository navigation
Conversation
sebastic
requested review from
bmribler,
brtnfld,
byrnHDF,
derobins,
fortnern,
glennsong09,
jhendersonHDF,
lrknox,
mattjala,
schwehr and
vchoi-hdfgroup
as code owners
September 5, 2026 16:16
Contributor
|
HDFGroup/hdf5#6220 may be of use if anyone wants to take this work on. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
includedir&libdirvariables in thepkg-configfile are incorrect when non-default paths are used usingHDF4_INSTALL_INCLUDE_DIR&HDF4_INSTALL_LIB_DIR.This is fixed by not hardcoding the subdirectories.
The resulting
hdf.pcstill has an issue, the private libs contain CMake targets:I don't know how to fix this, so left this out of scope for this PR.
Hopefully someone more familiar with CMake knows how to resolve these targets.