Skip to content

Fixed src file path in the output for accessibility - #2470

Open
sourabhbagrecha wants to merge 1 commit into
Graphify-Labs:v8from
sourabhbagrecha:v8
Open

Fixed src file path in the output for accessibility#2470
sourabhbagrecha wants to merge 1 commit into
Graphify-Labs:v8from
sourabhbagrecha:v8

Conversation

@sourabhbagrecha

Copy link
Copy Markdown

This PR updates the terminal output formatting for the graphify query command to improve developer experience (DX) and IDE compatibility.

Motivation and Context

Currently, the CLI output formats file paths without proper delimiters (e.g., src=apps/...). This causes VS Code's terminal link detector to include the src= prefix as part of the file path, breaking the standard Cmd/Ctrl + Click functionality to open files directly from the terminal.

Before:

Terminal output fails to parse the exact file path correctly:
image

Clicking the link results in an error because the IDE searches for a file explicitly named src=...:
image

Changes Made

  • Adjusted the string formatting of the node output to ensure file paths are cleanly separated from their labels.
  • This allows modern IDE terminals (like VS Code) to correctly identify and hyperlink the exact file path, improving overall CLI usability.

@graphify-labs graphify-labs Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks safe to merge — no coupling regressions and no blocking issues, checked against the code graph (not a self-assessment).

Graphify reviewed this change.

Looks safe to merge — no coupling regressions and no blocking issues, checked against the code graph (not a self-assessment).


Graphify review — findings

This pull request modifies the _subgraph_to_text function in graphify/serve.py, changing the formatting of the NODE metadata line. Specifically, it swaps the key=value separator style (e.g. src=, loc=, community=) to a key: value style with a space after the colon. The change appears purely cosmetic, affecting only how node source, location, and community attributes are rendered in the output text. Reviewers should verify whether any downstream parsing depends on the previous = delimiter format.

No blocking issues surfaced. 1 lower-confidence candidate did not survive cross-model review.

Analysis details — impact, health, verification

Impact & health

Graphify review

Impact — 406 functions depend on the 112 functions this change touches.

Health — grade A; 10 existing hotspot(s) in the area this change touches (pre-existing, not introduced here):

  • dispatch_command() — 2 callers, 111 callees (high)
  • _query_graph_text() — 14 callers, 8 callees (high)
  • _score_query() — 14 callers, 4 callees (high)
  • run_benchmark() — 16 callers, 3 callees (high)
  • _query_terms() — 16 callers, 3 callees (high)
  • _build_server() — 2 callers, 16 callees (high)
  • _load_graph() — 9 callers, 3 callees (medium)
  • _query_subgraph_tokens() — 6 callers, 3 callees (medium)
  • …and 2 more

Verification — 406 functions in the blast radius were not formally verified this run (proofs are advisory here).

Gate & verification

graphify gate

PASS — objectively clean (no health regressions, tests not run — proofs not run this pass (advisory)). Grounded, not self-assessed.

Advisory (not blocking):

  • verification_scope: 267 function(s) in the blast radius were not formally verified this run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant