Skip to content

chore(retail): update package dependencies - #4415

Draft
angelcaamal wants to merge 3 commits into
mainfrom
chore/retail-update-dependencies
Draft

chore(retail): update package dependencies#4415
angelcaamal wants to merge 3 commits into
mainfrom
chore/retail-update-dependencies

Conversation

@angelcaamal

Copy link
Copy Markdown
Contributor

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@product-auto-label product-auto-label Bot added api: retail Issues related to the Retail API API. samples Issues that are directly related to samples. labels Aug 21, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Node.js engine requirement to >=20.0.0, removes a duplicate engines block, and upgrades several dependencies and devDependencies in retail/package.json. A critical issue was identified with upgrading chai to v6.0.0, as Chai v5 and above are ESM-only and will cause tests to fail in this CommonJS project. It is recommended to keep chai at ^4.5.0 to maintain compatibility.

Comment thread retail/package.json
"c8": "^10.0.0",
"chai": "^4.5.0",
"c8": "^12.0.0",
"chai": "^6.0.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Chai v5 and above are ESM-only. Since this project uses CommonJS (require), upgrading to chai v6.0.0 will cause tests to fail with ERR_REQUIRE_ESM. It is recommended to keep chai at ^4.5.0 to maintain compatibility.

Suggested change
"chai": "^6.0.0",
"chai": "^4.5.0",

@angelcaamal
angelcaamal force-pushed the chore/retail-update-dependencies branch from e402ee7 to b11da1e Compare August 21, 2026 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: retail Issues related to the Retail API API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant