Repository navigation
Clean-up: remove JAVA_ENTITY_TYPES registry - #6832
Merged
eclipseisoffline merged 3 commits intoOct 30, 2026
Merged
Conversation
rtm516
approved these changes
Oct 29, 2026
rtm516
left a comment
rtm516
left a comment
Member
There was a problem hiding this comment.
All looks good. Just a little confused why we have a new GeyserResources class? It nice to split it out of the bootstrap but it feels like an extra class for not alot of use.
Member
Author
|
It's used in the |
SendableMetatype
pushed a commit
to EduGeyser/EduGeyser
that referenced
this pull request
Oct 30, 2026
* Remove JAVA_ENTITY_TYPES registry as BuiltInJavaRegistries#ENTITY_TYPE fully covers its use case * Fix tests: bootstrap BuiltInJavaRegistries in ScoreboardIssueTests * MCPL bump (cherry picked from commit e87ad14)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
JAVA_ENTITY_TYPESregistry (listed inRegistries), as all of its remaining use cases were covered by the modernBuiltInJavaRegistries#ENTITY_TYPEregistry. Please note that for this change, some modifications to unit tests were required. TheScoreboardIssueTestsunit test class now bootstraps the default (resolvable) data component registries, as well as theBuiltInJavaRegistries. There are some notes on this, see the comments in that class.The PR also bumps MCPL, which includes GeyserMC/MCProtocolLib#939, which fixes some nullability warnings across the project.